-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep 2.0.3 release #98
Merged
chrisbrickhouse
merged 34 commits into
JoFrhwld:master
from
chrisbrickhouse:release-prep
Mar 29, 2024
Merged
Prep 2.0.3 release #98
chrisbrickhouse
merged 34 commits into
JoFrhwld:master
from
chrisbrickhouse:release-prep
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to detec header
(cherry picked from commit 6bc72a4)
Update documentation for FAVE 2: * Include warning for old users on reading migration guide. * Write migration guide with FAQ * Simplify TOC code * Add index.rst for code and usage sections of docs * Add sphinx-project module into conf to make doc updates easier
This commit adds some testing for the cmudictionary.py module. In testing cmudictionary.CMU_Dictionary.add_dictionary_entries() a bug was uncovered in .check_transcription() which caused the output file to have more spaces than necessary. The cause was that function did not split the phone string when it was supposed to. This commit fixes the error and includes the test to prevent regression.
An error in cmudictionary.py caused add_dict to be overwritten and change type when a transcribed word was not in the cmu dictionary and had not yet been added to the output dictionary. This led to an obvious type error and a not obvious failure to add custom dictionaries. This commit fixes the issue by adding the given word as a key to add_dict and adds a test to prevent regressions. Resolves JoFrhwld#59
Resolves JoFrhwld#65 by checking the data type of the first time field. If it's not a float, we assume it's a header row and remove it from the returned list. Otherwise the function returns as previously. Squashed commit of DerMoehre's PR JoFrhwld#73 Co-authored-by: JoFrhwld <JoFrhwld@gmail.com> Co-authored-by: Christian Brickhouse <chrisbrickhouse@users.noreply.github.com>
This reverts commit 5983ed6.
* Update workflows to install package dependencies like numpy for use in tests * Cache installed dependencies so that future runs are faster * Upgrade setup-python to v4 from v3
…d#83)" (JoFrhwld#90) This reverts commit 25d7563.
Add flake8 and pytest as dev deps.
* Workflows upgraded to setup-python v4. * Workflows now install deps using poetry. * Lint and test run through poetry interface. * Deps cached for faster testing in later runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
New Contributors
Full Changelog: v2.0.2...v2.1.0